Repository navigation
Migrate Users.Actions shared directives to v3 wrappers - #3860
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
Conversation
Audit complete actual legacy and compatible sources; preserve four shared rename groups and document empty selectors without inventing removals. Ignore all profile-local directives. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the queued full Kiota 1.36.1 and wrapper Release pipeline against the pinned compatible spec: 17 compiled exports and 17/17 emitted-route parity. Client/cmdlet sources and projects are byte-equivalent after Git newline normalization; only the Kiota version lock changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full queued Kiota 1.36.1 and wrapper Release generation: 30 compiled exports, all 30 baseline routes retained, exactly four shared directive renames and 26 unchanged neighboring commands. Preserve tracked Beta casing. Client sources/projects are unchanged; lock files reflect the actual generator/version and compatible beta spec. Baseline Mg-vs-MgBeta and unrelated structural-name parity differences remain explicit limitations, not a claimed parity pass. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
October 22, 2026 04:59
Integrate normally merged multi-route framework without rebasing or changing module ownership. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Adapt module tests to the merged GeneratorConfig API and explicitly propagate the oracle profile through naming, suppression, overrides and full-spec service generation with derived data on and off. Refresh exact aligned operation IDs/spec blobs and audit three compatible-only beta actions without altering shared directive scope. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run fresh queued full Kiota and cmdlet Release generation against compatible spec 44eb54b on normally merged target 08e409a. Exit 0, Status OK, 17 compiled exports in 67.2s. Preserve all 17 prior action routes/names; real offline WhatIf and Confirm-No checks pass for all 17. Raw emitted-route parity 17/17; existing three derived suppressions unchanged. Client models and lock change with current spec; cmdlet/project outputs remain unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fresh queued full Kiota/cmdlet Release pipeline against compatible spec 4ab438c: exit 0, Status OK, 33 compiled exports in 132.3s. Preserve all 30 prior PR action names/routes and emit the three current compatible-only qualified identityGovernance actions. Real offline WhatIf and Confirm-No checks pass for all 33. Client models/builders and lock refresh; no authored operation-variant grouping or naming sweep. Raw beta parity remains 0/33 with baseline prefix/naming and oracle limitations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Normally integrate powershell-v3 844672d and preserve all existing module migration and profile generation commits. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Require every full-spec generated action to call GetRequestAdapter with its explicit v1.0 or beta runtime context and reject historical bare adapter calls. Preserve all existing shared source and naming dispositions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fresh queued full client/cmdlet/project/manifest pipeline on normal target 844672d: exit 0, Status OK, 17 exports in 46.4s. Emit v1.0 adapter context for every action and prune closure to three owned DLLs. Exact 17 prior action routes/names retained. Actual authenticated offline HTTP verifies typed nested payloads/results and bodyless actions; 17 WhatIf and genuine Confirm-No checks send zero HTTP; formerly RMS-blocked serializer succeeds with Auth-owned closure. Client and lock outputs regenerated unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fresh queued full client/cmdlet/project/manifest pipeline on normal target 844672d: exit 0, Status OK, 33 exports in 73.2s. Emit beta adapter context for every action and prune closure to three owned DLLs. All 33 prior action names/routes retained. Actual authenticated offline HTTP proves beta/cloud URL, typed action JSON/results, bodyless and qualified actions; 33 WhatIf and genuine Confirm-No checks send zero HTTP. Auth-owned serializer closes the historical RMS gap. Client and lock outputs regenerated unchanged; raw beta name parity remains an explicit baseline limitation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Normally integrate powershell-v3 6475f3f after required-query and one-operation PATCH contract changes; preserve own migration and profile-generation history. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Pin the complete actual20v1/33beta compatible module surfaces as POST actions with path-only parameters. No module PATCH or required query/header input exists; retain prior directive outcomes and avoid inventing no-readback or query mutations. Combined411module/configurator/naming/required-query/PATCH contract tests pass with nonempty TRX. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run complete sequential queued Kiota+cmdlet/client/project/manifest Release generation against target6475f3f5be: exit0StatusOK17exports71.5s; explicit no-incremental build passes. Generated source byte-identical. Supplemental no-build actual package imports prove exact17routes/names, typed authenticated HTTPGlobal/USGov,17WhatIf/genuineConfirmNo0HTTP, context/reconnect/logout and actual post-import MockDataStore isolation. Preserve separate honest generation commit without fabricated changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota+cmdlet/client/project/manifest Release build against target6475f3f5be: exit0StatusOK33exports149.5s, supplemental no-incremental build passes. Generated source is byte-identical. Real normal packageGlobal/USGov transport proves all33routes/names, shared action typedpayload/results, correctbetaURL,33WhatIf/genuineConfirmNo0HTTP, lifecycle/cache and actual post-import MockDataStore guards. Frozen rawbeta0/33 naming limits retained; no fabricated generated delta. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
src\readme.graph.mdremain ignored and unmodified. Parameter aliases/transforms and schema/response classes remain deferred.powershell-v3target6475f3f5beb4908d39ea356db32bf1e0fd3273cbthrough merge6349b2d48eab3852e403ac7a8d4ce464aebb45b5, preserving prior head9f290d0b1576a4473e5778a57f199f6b73ae6fe1and all original migration/profile-generation boundaries. Own correctionab2ea38a79bb928ea2cde1e04c4032eb5ccba25epins complete actual module PATCH/query applicability; it does not add or suppress APIs.Source and applicability
The ORIGINAL shared suppression regex matches zero actual legacy and zero actual compatible IDs in both profiles. No API removal is inferred from an empty selector. All 50 legacy operations have actual same-method/parent, POST/action metadata-guarded final-terminal counterparts; old qualified paths and current aligned IDs are retained in audit evidence. Three qualified current-only beta identityGovernance actions are separately inventoried, with no invented predecessor or suppression.
Four shared rename groups survive:
Remove-MgAllUserDeviceFromManagement,Update-MgUserPasswordin both profiles; betaInvoke-MgInvalidateAllUserRefreshTokenandGet-MgUserOwnedObjectByType. Seven exact method/path fallbacks preserve these outcomes while v1.0 derived names remain authoritative. The other 12 groups genuinely select no same-module operations. No reserved Legacy integration fields, guessed numbered variants or profile-local behavior. Frozen v1.0 derived suppressions of POST/users/{user-id}/restore,/users/{user-id}/wipeManagedAppRegistrationsByDeviceTag, and/users/getAvailableExtensionPropertiesremain unchanged and visible in the whole-spec audit.Whole-module spec/test audit confirms POST actions only, path-only parameters, no GET/PATCH/PUT/DELETE, no header/query inputs and no authored grouped alternatives/defaults. The new PATCH204 one-request/no-object/no-GET and native required
Query<Name>contracts are therefore N/A to this module, not untested mutations silently waived or fabricated. Shared bodyless actions remain POST even when their cmdlet verb is Remove. Existing three v1.0 derived suppressions remain unchanged.Final current-target proof
Evidence root:
C:\Users\ramsess\.copilot\session-state\9e8ee2ef-46e4-4c17-947c-d6c04b6c3dbb\files\post3886-6475-final.Historical
post3849andpost3891-844672logs remain untouched and are not current6475 proof.Results: 411 total/executed/passed, 0 failed/not-executed, native exit0, recorded in actual nonempty TRX; 16 Mapped, 0 Deferred/Unresolved/Invalid, exit0. Broader companion tests include the new one-operation PATCH and required-query rules; the actual module-specific audit proves their N/A status. Existing NU1903 advisory remains unchanged.
Process-local tools: existing Kiota 1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943,
KIOTA_Generation__MaxDegreeOfParallelism=1, .NET 10.0.403, PowerShell 7.6.9. PSModulePath begins with the exact adapted normally packaged Authentication2.41.2 root:C:\Users\ramsess\.copilot\session-state\4aa86cf9-d43c-4d2b-a4a3-aeaed01b8f29\files\authentication-v2-sync\final-source\modules.Fresh child imports verify that root/version. All64 fileSHA256s and physical packageSHA256
2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EBare verified. Shipping Auth/runtime/template/builder sources remain identical to the accepted normal package producer. No stock gallery/old2.38/shim/copied dependency.44eb54b2d295130bf275b63c4c81fbd8bf0e892d161a667ae1163bbec5a300d87a7a3285ba85170f4ab438c0bb4ec50612ad4e9866b6dd6a18109fbd855f5e2151b45aa6b89f52ac3fd757274cb4dcf1Exact full pipelines are invoked by the current recorded harness, v1.0 then beta:
Each harness runs the unchanged four-slot
Invoke-QueuedModuleBuild.ps1 -RepoRoot <same worktree> -Module Users.Actions -ApiVersion <profile> -Configuration Releasewith the exact process-local environment, full Kiota+cmdlet/client/project/manifest generation and no skip flags or legacy fallback. Supplementaldotnet build ... -c Release --no-incrementalforces current module output; generator Release no-incremental validation also recorded. Per-command paths/arguments/exits incommands-<profile>.json; raw logsfull-v1.0.log/full-beta.log.Both supplemental no-incremental module builds pass exit0. All client/cmdlet/project/lock source output is genuinely byte-identical to the integrated source; generated manifests/binaries/packages were recreated and hashed. The separate profile generation boundaries are honest empty commits: v1.0
c24afa44f2b3f0583d01b1b93eac330da29a08c1, beta702e3044b28263271c765a909a7786298e3775d9.Supplemental
Pack-FinalProfile.ps1 -RepoRoot <same worktree> -Profile <profile>uses actualdotnet pack <module.csproj> -c Release --no-buildagainst the completed normal bin/manifest, with the same package files/Auth floor as the repository builder. Package extraction verifies exactly three owned DLLs, no RequiredAssemblies/NestedModules, Auth2.41.2 requirement and exact normal DLL/manifest hash equivalence; no new generation run solely for packing.Real packaged runtime:
The harness imports the extracted normal package and runs
Test-UsersActionsAuthenticated.ps1 -Profile <profile> -Environment Global|USGov -ManifestPath <extracted.psd1> -RepoRoot <same worktree>in fresh children. Exact commands/native results are retained inruntime-exits-<profile>.json.Results: both profile harnesses passed native exit0; all four Global/USGov package-import runs passed. Each v1.0 cloud run sends exactly 12 actual authenticated POSTs: six representative generated actions, four actual profile-alternation calls, and two generated lifecycle/reconnect actions. Each beta cloud run sends exactly 17 POSTs: eleven representative generated actions, four alternations, and two lifecycle/reconnect actions. Across all four runs there are 58 intercepted real-pipeline HTTP requests, with exact body/header/typed-result assertions, separate zero-HTTP safety counters and native exits; these are not inferred from source inspection.
Memory isolation is asserted on the actual shared session: after the last additional-runspace module import, the existing
Set-MgTestDataStorehelper is reapplied before first Connect. Guard snapshots verify actualMicrosoft.Graph.Authentication.Test.Mocks.MockDataStorebefore every generated HTTP/safety call, profile alternation, context change, reconnect and logout/disconnect: 37 actual checks per v1.0 cloud run, 58 per beta cloud run. All recorded types match the real expected MockDataStore, not a label. This guard was incorporated before the first final runtime run, so no older runtime proof was overwritten/recast and no completed full build/TRX was rerun for the setup correction. No credential I/O is inferred merely from old unguarded datastore types. No production OnImport/session/loader changes.Actual authenticated
Connect-MgGraph+ normalGraphHttpClientFactorytoken pipeline + test-only terminal capture proves typed password JSON, nested AssignedLicense/Guid arrays and typed User result, string-array scalar collection result, discriminator User collection, nested Message body, bodyless actions, shared ByType/boolean beta outcomes and qualified actions. All17/33 prior names/routes and 15/29 unaffected neighbors retain exact compiled metadata. All50 WhatIf and genuine Confirm-No paths send0HTTP, one actual prompt per declined mutation; invalid Guid bindings fail beforeHTTP.Each Global/USGov run checks shared factory BaseAddress still
/v1.0, while actual generated beta/cloud requests use/beta; four real alternating-profile HTTP calls preserve roots/token/client. Same client/root adapter reuse, request-context invalidation/rebuild with42s timeout, reconnect with new token/client/adapter and disconnected NoGraphSession0HTTP are checked. No live Graph/OAuth or credential store. Current captures contain POST only; no hidden GET/readback.Formerly blocked standalone
ToPostRequestInformationtyped JSON serialization is separately verified passing with the normal Auth-owned RMS/URI/Multipart closure, alongside independent full generated-command authenticated HTTP. Single normal Auth/Kiota dependency identities and correct package source/load contexts are recorded.Raw parity remains honest: v1.0 17/17 emitted routes, exit0; beta 0/33 raw parity, exit1 with frozen Mg-vs-MgBeta/unrelated-name differences and five oracle omissions. This is not a prefix-normalized all-surface naming pass or real tenant service certificate. PowerShell5.1 is unsupported. No unrelated optional query work, #3881 overlays, missing-API guesses or automatic merge.
Preserved history
Original migration/generation:
5f3915dd3f,2be8617d1b,32f3d57ea3.Post3849:
e08c6c7d91,9e8df68193,2688c16317,8afad5a8c0.Post3891:
7dd987d3ec,27f1313478,4e369b4b10,9f290d0b15.Current normal merge
6349b2d48eand own applicability testab2ea38a79; separate final v1/beta combined generation commits are additive. All commits include Copilot App coauthor. Byte-identical regeneration uses an explicitly honest empty boundary only where there is no source delta. No bin/obj/DLL/nupkg/log/secrets committed; tracked Beta casing preserved.Final canonical PR head:
702e3044b28263271c765a909a7786298e3775d9.handoff.jsonretains actual scalar counters, full uncapped/no-rename Git path evidence, exact package/normal-manifest/assembly hashes and every absolute artifact path/SHA256. No claims of live Graph validity, extra required-query support or all-surface name parity.Other links